Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Map span status properly to GCT #113

Merged
merged 1 commit into from
Mar 18, 2021

Conversation

aabmass
Copy link
Collaborator

@aabmass aabmass commented Mar 18, 2021

Fixes #105

Map status correctly. Typescript impl for reference.

@google-cla google-cla bot added the cla: yes label Mar 18, 2021
@aabmass aabmass force-pushed the fix-statuscode-105 branch 2 times, most recently from 7c740f7 to adf3dbd Compare March 18, 2021 19:45
@aabmass aabmass requested a review from a team March 18, 2021 19:47
@aabmass aabmass force-pushed the fix-statuscode-105 branch from adf3dbd to 69c6b05 Compare March 18, 2021 20:01
@aabmass aabmass marked this pull request as ready for review March 18, 2021 21:04
@aabmass aabmass merged commit bb517e1 into GoogleCloudPlatform:master Mar 18, 2021
@aabmass aabmass deleted the fix-statuscode-105 branch March 18, 2021 21:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

OpenTelemetry span status code does not map directly to google.rcp.Code
2 participants